[vlc-devel] [PATCH] Don't restart playlist after converting current item to node

Pierre d'Herbemont pdherbemont at free.fr
Mon Aug 18 22:06:39 CEST 2008

On Aug 18, 2008, at 1:39 AM, bl4 wrote:

>> 1- it doesn't apply cleanly.
> I guess that whatever patch I attach you'll say that it doesn't apply.
> There's nothing I can do about it.

*sigh* This has nothing to do with you :) it just didn't apply.

Though, I have re-checked it, it applies cleanly now. Sorry about  
that, I may have been using a not up to date tree back then, or a  
private branch without noticing.

>> 2- status.p_item not status.p_node should be used directly. Please  
>> use
>> the new accessors.
> The patch uses p_node->i_children and p_node->pp_children. I don't see
> how p_item could replace them.

Ok, I'll explain more:

> +                while( i < p_playlist->status.p_node->i_children &&
> +                       p_playlist->status.p_node->pp_children[i] !=  
> p_playlist->status.p_item )
> +                {
> +                    p_prev_status_item = p_playlist->status.p_node- 
> >pp_children[i];

You shouldn't access p_playlist->status.p_node nor p_playlist- 
 >status.p_item directly. Instead use get_current_status_node() and  
get_current_status_item() instead.

That's all I was saying, so, not a big deal :)


More information about the vlc-devel mailing list