[vlc-devel] [PATCH] Don't restart playlist after converting current item to node

[Pierre d'Herbemont]

On Aug 19, 2008, at 10:13 PM, bl4 wrote:

> Pierre d'Herbemont wrote:
>> On Aug 18, 2008, at 1:39 AM, bl4 wrote:
>>>> 1- it doesn't apply cleanly.
>>>>
>>> I guess that whatever patch I attach you'll say that it doesn't  
>>> apply.
>>> There's nothing I can do about it.
>> *sigh* This has nothing to do with you :) it just didn't apply.
>
> Well, when saying that the patch was incorrect, you expected me as  
> the sender to fix it and resend.
>
>> Though, I have re-checked it, it applies cleanly now. Sorry about   
>> that, I may have been using a not up to date tree back then, or a   
>> private branch without noticing.
>>>> 2- status.p_item not status.p_node should be used directly.  
>>>> Please  use
>>>> the new accessors.
>
> I just misunderstood that: status.p_item NOT status.p_node...

Yeah, I mean "nor" not "not" :/
>
>> Ok, I'll explain more:
>>> +                while( i < p_playlist->status.p_node->i_children &&
>>> +                       p_playlist->status.p_node->pp_children[i] ! 
>>> =  p_playlist->status.p_item )
>>> +                {
>>> +                    p_prev_status_item = p_playlist->status.p_node-
>>>> pp_children[i];
>> You shouldn't access p_playlist->status.p_node nor p_playlist-   
>> >status.p_item directly. Instead use get_current_status_node() and   
>> get_current_status_item() instead.
>
> I've changed the attached patch to use these accessors.

Thanks a lot!

> From b03900bf8a3e7fe4e46845529a7fc8ff7bce9649 Mon Sep 17 00:00:00 2001
> From: Przemyslaw Fiala <bl4 at playker.info>
> Date: Tue, 19 Aug 2008 21:47:57 +0200
> Subject: [PATCH] Don't restart playlist after converting current  
> item to node

Patch applied, Thanks!

Pierre.