[vlc-devel] commit: macosx: In bookmarks's dealloc, we shouldn' t release the p_old_input ptr, as we have already released it. (Pierre d' Herbemont )

[git version control]

vlc | branch: master | Pierre d'Herbemont <pdherbemont at videolan.org> | Wed Aug 20 08:58:57 2008 +0200| [538ec8f8cfe8e30ee54683bd01ccc929f374d4b8] | committer: Pierre d'Herbemont 

macosx: In bookmarks's dealloc, we shouldn't release the p_old_input ptr, as we have already released it.

This should fix a crash reported in our bugreport ml.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=538ec8f8cfe8e30ee54683bd01ccc929f374d4b8
---

 modules/gui/macosx/bookmarks.m |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/modules/gui/macosx/bookmarks.m b/modules/gui/macosx/bookmarks.m
index 5c562b0..f0fb02e 100644
--- a/modules/gui/macosx/bookmarks.m
+++ b/modules/gui/macosx/bookmarks.m
@@ -76,8 +76,6 @@ static VLCBookmarks *_o_sharedInstance = nil;
 
 - (void)dealloc
 {
-    if( p_old_input )
-        vlc_object_release( p_old_input );
     [super dealloc];
 }
 
@@ -188,6 +186,9 @@ static VLCBookmarks *_o_sharedInstance = nil;
             pp_bookmarks[row]->i_byte_offset] stringValue]];
     }
  
+    /* Just keep the pointer value to check if it
+     * changes. Note, we don't need to keep a reference to the object.
+     * so release it now. */
     p_old_input = p_input;
     vlc_object_release( p_input );