[vlc-devel] Bookmarks: close #1661 : This does not compile

[Jean-Baptiste Kempf]

Fixed in [f909b91d66a7969ec7e54a8108390ac2d3289a8b].

On Thu, Aug 21, 2008 at 11:40:51PM +0200, Gilles Sabourin wrote :
> About commit d06c11b5740a657eba8dd3bac9382ffa5b9bb848
> 
> Author: Jean-Baptiste Kempf <jb at videolan.org>  2008-08-21 23:18:31
> Committer: Jean-Baptiste Kempf <jb at videolan.org>  2008-08-21 23:19:09
> Parent: 543a14198e2fa2367468864f2c3d6df91e18c21c (dvdnav: switch to the 
> activated color sooner)
> Branches: remotes/origin/master, master
> Follows: 0.9.0-test3
> Precedes: 
> 
>     Bookmarks: close #1661
> 
> -------------------- 
> modules/gui/qt4/dialogs/bookmarks.cpp --------------------
> index 68f0fa4..5333783 100644
> @@ -141,7 +141,8 @@ void BookmarksDialog::add()
>  
>      seekpoint_t bookmark;
>      vlc_value_t pos;
> -    bookmark.psz_name = NULL;
> +    bookmark.psz_name = qtu( THEMIM->getIM()->getName() +
> +                    QString("_%1" ).arg( 
> bookmarksList->topLevelItemCount() ) );
>      bookmark.i_byte_offset = 0;
>      bookmark.i_time_offset = 0;
>  
> ================================================================================
> /bin/sh ../../../libtool --tag=CXX   --mode=compile 
> g++ -DHAVE_CONFIG_H -I. -I../../..   -I../../../include -I../../../include  -DSYS_LINUX 
> `top_builddir="../../.." ../../../vlc-config --cxxflags plugin 
> dialogs/libqt4_plugin_la-bookmarks.lo` -g -O2 -MT 
> dialogs/libqt4_plugin_la-bookmarks.lo -MD -MP -MF 
> dialogs/.deps/libqt4_plugin_la-bookmarks.Tpo -c -o 
> dialogs/libqt4_plugin_la-bookmarks.lo `test -f 'dialogs/bookmarks.cpp' || 
> echo './'`dialogs/bookmarks.cpp
>  
> g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../include -I../../../include -DSYS_LINUX -D_FILE_OFFSET_BITS=64 -D__USE_UNIX98 -D_LARGEFILE64_SOURCE -D_REENTRANT -D_THREAD_SAFE -DDEBUG -D__LIBVLC__ -D__PLUGIN__ -DMODULE_NAME=qt4 -DMODULE_NAME_IS_qt4 -DMODULE_STRING=\"qt4\" -g -O0 -DQT_SHARED -I/usr/include/QtCore -I/usr/include/QtGui -DQT4LOCALEDIR=\"/usr/share/qt4/translations/\" -g -O2 -MT 
> dialogs/libqt4_plugin_la-bookmarks.lo -MD -MP -MF 
> dialogs/.deps/libqt4_plugin_la-bookmarks.Tpo -c 
> dialogs/bookmarks.cpp  -fPIC -DPIC -o 
> dialogs/.libs/libqt4_plugin_la-bookmarks.o
> dialogs/bookmarks.cpp: In member function 'void BookmarksDialog::add()':
> dialogs/bookmarks.cpp:144: error: 'class InputManager' has no member 
> named 'getName'
> make[6]: *** [dialogs/libqt4_plugin_la-bookmarks.lo] Error 1
> make[6]: Leaving directory 
> `/usr/src/packages/BUILD/vlc-beta-0.9.0/modules/gui/qt4'
> make[5]: *** [all] Error 2
> make[5]: Leaving directory 
> `/usr/src/packages/BUILD/vlc-beta-0.9.0/modules/gui/qt4'
> make[4]: *** [all-recursive] Error 1
> make[4]: Leaving directory 
> `/usr/src/packages/BUILD/vlc-beta-0.9.0/modules/gui'
> make[3]: *** [all] Error 2
> make[3]: Leaving directory 
> `/usr/src/packages/BUILD/vlc-beta-0.9.0/modules/gui'
> make[2]: *** [all-recursive] Error 1
> make[2]: Leaving directory `/usr/src/packages/BUILD/vlc-beta-0.9.0/modules'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/usr/src/packages/BUILD/vlc-beta-0.9.0'
> make: *** [all] Error 2
> 
> 
> Best regards,
> Gilles



> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel


-- 
Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/