[vlc-devel] commit: Fix memleak (should fix #1081) ( Rémi Duraffort )

Pierre d'Herbemont pdherbemont at free.fr
Mon Aug 25 01:32:02 CEST 2008


On Aug 25, 2008, at 12:35 AM, Ilkka Ollakka wrote:

> On su 24. elokuuta 2008 21:14:35, git version control wrote:
>> vlc | branch: master | Rémi Duraffort <ivoire at videolan.org> | Sun  
>> Aug 24 20:56:56 2008 +0200|  
>> [4774dc6c9f7b04b40f90e4edc9ad1a1f8d256f1d] | committer: Rémi  
>> Duraffort
>>
>> Fix memleak (should fix #1081)
>>
>
> This seems to cause segfault for me when module is unloaded in 64bit
> linux.

The patch is wrong anyway: strangely in_block ownership goes to the  
packetizer. IMO, we don't have refcounting for block, and that doesn't  
seem right. And that convention is really counter intuitive. (and  
prone to leak)

Remi, time for 0.9.1 :/

Pierre.


More information about the vlc-devel mailing list