[vlc-devel] commit: Revert "Fix memleak in mkv." (Jean-Baptiste Kempf )

[Derk-Jan Hartman]

Hmm, what happened here ?

DJ

On 25 aug 2008, at 09:41, git version control wrote:
> vlc | branch: master | Jean-Baptiste Kempf <jb at videolan.org> | Mon  
> Aug 25 00:44:59 2008 -0700|  
> [5ca01aec25d467af7197eda4a368a341d41a3764] | committer: Jean- 
> Baptiste Kempf
>
> Revert "Fix memleak in mkv."
>
> This reverts commit 9b868a2f52eef2eb456831d296428aac98419bca.
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=5ca01aec25d467af7197eda4a368a341d41a3764
> ---
>
> modules/demux/mkv.cpp |    4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/modules/demux/mkv.cpp b/modules/demux/mkv.cpp
> index a20c8e4..994648d 100644
> --- a/modules/demux/mkv.cpp
> +++ b/modules/demux/mkv.cpp
> @@ -5005,9 +5005,7 @@ void  
> matroska_segment_c::ParseAttachments( KaxAttachments *attachments )
>
>         if( new_attachment )
>         {
> -            char* tmp = ToUTF8( UTFstring( file_name ) );
> -            new_attachment->psz_file_name  = tmp;
> -            free( tmp );
> +            new_attachment->psz_file_name  =  
> ToUTF8( UTFstring( file_name ) );
>             new_attachment->psz_mime_type  = psz_mime_type;
>             new_attachment->i_size         = img_data.GetSize();
>             new_attachment->p_data         =  
> malloc( img_data.GetSize() );
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>