[vlc-devel] [PATCH][SoC] Qt improvements

Rémi Denis-Courmont rem at videolan.org
Sun Aug 31 12:19:36 CEST 2008


Le vendredi 29 août 2008 17:42:56 Lukas Durfina, vous avez écrit :
>     there is patch with part of my SoC project Qt improvements.
> It contains new features/functions for libVLC used by phonon-vlc
> backend which I have developed in my project.

diff --git a/include/vlc/libvlc_events.h b/include/vlc/libvlc_events.h
index 1aa0f2f..524c349 100644
--- a/include/vlc/libvlc_events.h
+++ b/include/vlc/libvlc_events.h
@@ -66,6 +66,7 @@ typedef enum libvlc_event_type_t {
+    libvlc_MediaPlayerTitleChanged,

That would break the ABI. When extending enums, please use free slots.

+        aout_EnableFilter( ( vlc_object_t * ) p_aout->p_libvlc, 

Is there any reason why you do not use the VLC_OBJECT() macro? there are many 
instance of this.

+libvlc_filter_parameter_list_t *libvlc_filter_get_parameters(
+              module_t *p_module,
+              libvlc_exception_t *p_e )

I don't mind using the "internal" libvlccore module_t pointers for external 
libvlc users, so long as they're used as opaque data. However "module_t" 
looks too generic a name for use outside of libvlccore.

Rémi Denis-Courmont

More information about the vlc-devel mailing list