[vlc-devel] commit: Fix croppadd out of bounds write (we were padding ' paddleft+paddright' pixels on the right instead of 'paddright') ( Antoine Cellerier )

git version control git at videolan.org
Sun Aug 31 16:08:53 CEST 2008


vlc | branch: 0.9-bugfix | Antoine Cellerier <dionoea at videolan.org> | Sun Aug 31 16:10:14 2008 +0200| [a790d0b5b0340f780351a3b54eda44d62742415e] | committer: Antoine Cellerier 

Fix croppadd out of bounds write (we were padding 'paddleft+paddright' pixels on the right instead of 'paddright')
(cherry picked from commit 90f041527795b54eb41713414ccc22e5d72887bb)

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=a790d0b5b0340f780351a3b54eda44d62742415e
---

 modules/video_filter/croppadd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/modules/video_filter/croppadd.c b/modules/video_filter/croppadd.c
index 3f9f648..0139b71 100644
--- a/modules/video_filter/croppadd.c
+++ b/modules/video_filter/croppadd.c
@@ -286,7 +286,7 @@ static picture_t *Filter( filter_t *p_filter, picture_t *p_pic )
 
             /* Padd on the right */
             vlc_memset( p_out, i_padd_color,
-                        ( i_outwidth - i_width ) * i_pixel_pitch );
+                        ( i_outwidth - i_xpadd - i_width ) * i_pixel_pitch );
 
             /* Got to begining of the next line */
             p_in = p_in_next;




More information about the vlc-devel mailing list