[vlc-devel] [PATCH][SoC]OpenGL shader support aka GLSL

Rémi Denis-Courmont rem at videolan.org
Sun Aug 31 22:02:08 CEST 2008


Le dimanche 31 août 2008 22:51:38 Kaarlo Räihä, vous avez écrit :
> As part of my GSoC, I added OpenGL shader support to OpenGL video output
> module.

You seem to be using non-constant global variables.
Is there any reason for this? If so, you probably should mark them as static, 
and use a process-wide lock to protect against concurrent access (e.g. 
var_AcquireMutex()). Otherwise, these should probably be in the filter 
private data (vout_sys_t).


Rémi Denis-Courmont

More information about the vlc-devel mailing list