[vlc-devel] [PATCH] -- media_list
rem at videolan.org
Sun Dec 7 20:41:56 CET 2008
Le vendredi 5 décembre 2008 15:31:08 brezhoneg1, vous avez écrit :
> This patch corrects several bugs that prevent media_list (libvlc api) to
> work at all (transition from one item to the next).
> I'm re-sending it just in case it was forgotten (and before other
> changes occur that makes it un-applicable)
I don't see the point of checking for NULLity when clearing an exception.
IMHO, it would make more sense to assert against that stupid case.
More importantly, you cannot create a thread and forget about it. That would
be a major leak, especially w.r.t. the address space. Any thread MUST be
joined somewhere and preferrably as early as possible.
Sorry, but this patch looks pretty bad to me.
More information about the vlc-devel