[vlc-devel] [PATCHv2] WinCE: fix cancellation safety

[Pierre Ynard]

Fix cancellation safety on WinCE. This very obnoxious bug prevents
proper thread cancellation, and effectively causes lock-ups when trying
to stop playback.


diff --git a/src/misc/messages.c b/src/misc/messages.c
index 8f44837..a1b9530 100644
--- a/src/misc/messages.c
+++ b/src/misc/messages.c
@@ -556,7 +556,6 @@ static void PrintMsg ( vlc_object_t * p_this, msg_item_t * p_item )
             return;
     }
 
-    int canc = vlc_savecancel ();
 #ifdef UNDER_CE
 #   define CE_WRITE(str) WriteFile( QUEUE.logfile, \
                                     str, strlen(str), &i_dummy, NULL );
@@ -570,6 +569,7 @@ static void PrintMsg ( vlc_object_t * p_this, msg_item_t * p_item )
     FlushFileBuffers( QUEUE.logfile );
 
 #else
+    int canc = vlc_savecancel ();
     /* Send the message to stderr */
     utf8_fprintf( stderr, "[%s%p%s] %s%s%s %s%s: %s%s%s\n",
                   priv->b_color ? GREEN : "",


Regards,

-- 
Pierre Ynard
"Une âme dans un corps, c'est comme un dessin sur une feuille de papier."