[vlc-devel] Fwd: [PATCH] Corrected comparison in RTP port selection.

Vicente Jiménez googuy at gmail.com
Tue Dec 9 20:12:03 CET 2008

I resent to the list the patch that I sent to Rémi only after making
some corrections, one week ago.
It corrects that if the first stream is audio or video the following
time it tries to find a port number, this port is compared against 0
not the value passed with port-video or port-audio.


---------- Forwarded message ----------
From: Vicente Jiménez <googuy at gmail.com>
Date: Wed, Dec 3, 2008 at 12:10 AM
Subject: Re: [vlc-devel] [PATCH] Corrected comparison in RTP port selection.
To: Rémi Denis-Courmont <rem at videolan.org>

This is the patch corrected.

On Tue, Dec 2, 2008 at 6:33 PM, Vicente Jiménez <googuy at gmail.com> wrote:
> This is what I thought. But normally is only a few iteration (one or two). Anyhow I correct this to only call it once by elementary stream.
> To call it only once at stream out creation, a change of data structures is needed.
> I also remove the break sentence and duplication of += 2. Perhaps the break is quicker, than doing again the while comparison. But I think this is an unneeded optimization.
> On Tue, Dec 2, 2008 at 6:20 PM, Rémi Denis-Courmont <rem at videolan.org> wrote:
>> Le mardi 2 décembre 2008 17:36:00 Vicente Jiménez, vous avez écrit :
>> > Sorry, some late night effect.Now is attached.
>> Iterating over var_GetInteger() is not a good idea.
>> --
>> Rémi Denis-Courmont
>> http://git.remlab.net/cgi-bin/gitweb.cgi?p=vlc-courmisch.git;a=summary
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Corrected-comparison-in-RTP-port-selection.patch
Type: application/octet-stream
Size: 1421 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20081209/865ae5a6/attachment.obj>

More information about the vlc-devel mailing list