[vlc-devel] [PATCH] Added libvlc_get_internal_object functions to the PUBLIC API

[basos g]

2008/12/11 Rémi Denis-Courmont <rem at videolan.org>:
> Le jeudi 11 décembre 2008 22:12:02 basos g, vous avez écrit :
>> You are right. I haven't thought of it. It worked from vlccore
>>
>> New version of the API. Now it is moved to vlc_main.h and is
>> implemented at src/libvlc.c thus libvlccore.dll
>>
>> Also diffed against trunk
>
> I get an undeclared function call. Please test your patches.
>
> Also, you should drop the retain and release functions - they're totally
> useless aliases. And don't #include libvlc stuff in vlc_main.h. Instead
> you can do this (of course you still need to #include it in src/libvlc.c):
>
>   struct libvlc_instance_t;
>
>   VLC_EXPORT( libvlc_int_t *, libvlc_get_internal_object, ( struct libvlc_instance_t * ) );
>
Yes sorry that patch worked on 0.9.5 but now something broke. I'll
test and report again.

You mean release is not needed. Why? The alias is just for libvlc_*
api compliance.
E.g. one should call libvlc_get_internal_object, do something with it
and finally libvlc_release_internal_object instead of the more cryptic
vlc_object_release

Also i suppose vlc_object_yield has been replaced by vlc_object_hold .

>
> --
> Rémi Denis-Courmont
> http://git.remlab.net/cgi-bin/gitweb.cgi?p=vlc-courmisch.git;a=summary
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>