[vlc-devel] [PATCH] Added libvlc_get_internal_object functions to the PUBLIC API

[basos g]

2008/12/12 Rémi Denis-Courmont <rdenis at simphalempin.com>:
>
> On Fri, 12 Dec 2008 04:32:47 +0200, "basos g" <noxelia at gmail.com> wrote:
>> You mean release is not needed. Why? The alias is just for libvlc_*
>> api compliance.
>
> Yeah and I don't want to clutter libvlccore with useless aliases. That's a
> waste of memory and linker CPU usage.
>
>> E.g. one should call libvlc_get_internal_object, do something with it
>> and finally libvlc_release_internal_object instead of the more cryptic
>> vlc_object_release
>
> And what's the point? You will NEED to cast it to vlc_object_t or
> libvlc_int_t anyway! otherwise, you would not use the internal object in
> the first place...
>

Ok that's true.
I dropped release and retain functions.
Also i renamed the get function to
vlc_object_t*  vlc_get_libvlc_object ( libvlc_instance_t* )
to comply with vlc_object_release( vlc_object_t* )

And just a question from curriosity : Is is really a problem to
include vlc/libvlc_structures.h into vlc_main.h ? Is it a policy to
not mix includes ?