[vlc-devel] [PATCH] Add Apple AirTunes stream output plugin
rem at videolan.org
Mon Dec 15 19:48:31 CET 2008
Le samedi 13 décembre 2008 01:12:28 Michael Hanselmann, vous avez écrit :
> > Is AirTunes a trademark or anything?
> Yes, unfortunately it is. I didn't even think of this before. Would
> "raop" (for Remote Audio Output Protocol) be a better name for the
Yeah, and please squash your fixes while you're at it (git rebase -i ...)
> The "remoteosd" plugin also has its own configure option and has the
> same dependencies. What do you prefer?
I prefer fewer options, and nobody else has commented this far.
> >> + /* Fill buffer */
> >> + memcpy( p_sys->p_sendbuf, header, sizeof( header ) );
> >> + memcpy( p_sys->p_sendbuf + sizeof( header ),
> >> + p_buffer->p_buffer, p_buffer->i_buffer );
> > What about using block_Realloc() instead?
> Do mean to use a block_t instead of a manually malloc'ed buffer? Or to
> do the encryption directly in the buffer passed to Send()?
Yes, if it makes sense (which is to say, if it saves reallocation and/or
More information about the vlc-devel