[vlc-devel] [PATCH] Add Apple AirTunes stream output plugin

[Michael Hanselmann]

Hi Rémi

2008/12/15 Rémi Denis-Courmont <rem at videolan.org>:
> On Sat, 13 Dec 2008 14:42:38 +0100, "Michael Hanselmann" <public at hansmi.ch>
> wrote:
>> I just tested it using Apple iTunes (actual IP addresses obfuscated
>> because to the MAC address encoded in them):
>>
>> "ANNOUNCE rtsp://fe80::216:1234:567:89/2822725808 RTSP/1.0
>> […]
>> o=iTunes 2822725808 0 IN IP4 fe80::321:1234:567:89
>> s=iTunes
>> c=IN IP4 fe80::123:9876:543:21
>> t=0 0
>> […]"
>>
>> It still uses "IP4", despite the underlying protocol being IPv6.
>
> Should add a comment on this then. Also make sure you're not including the
> scope ID in the SDP.

I added such a comment, even though the plugin does not yet support
IPv6 at all. It's not something I target for in this first version.

--- a/modules/stream_out/raop.c
+++ b/modules/stream_out/raop.c
@@ -865,5 +865,8 @@ static int AnnounceSDP( vlc_object_t *p_this, char
*psz_local,
     RemoveBase64Padding( psz_sac_base64 );

-    /* Build SDP */
+    /* Build SDP
+     * Note: IPv6 addresses also use "IP4". Make sure not to include the
+     * scope ID.
+     */
     i_rc = asprintf( &psz_sdp,
                      "v=0\r\n"

Regards,
Michael

-- 
http://hansmi.ch/