[vlc-devel] [PATCH] Un-deprecate __vlc_object_find

[Michael Hanselmann]

2008/12/16 Rémi Denis-Courmont <rem at videolan.org>:
> Le lundi 15 décembre 2008 00:07:03 Michael Hanselmann, vous avez écrit :
>> Rémi Denis-Courmont marked vlc_object_get as deprecated in commit
>> 50ee88d2ff74ca17c6350a198a3c4b7ec438ec9b (August 28, 2008). In commit
>> fddff181aa82b3a8c9ba1fd7ca81da54b1f8fb45 (September 20, 2008), he
>> removed vlc_object_get completely, forgetting the attribute marking
>> the function as deprecated. GNU compilers are now complaining
>> about vlc_object_find ("warning: '__vlc_object_find' is deprecated
>> (declared at ../../include/vlc_objects.h:82)").
>
> Hmm. I wonder if this was an accident :) It is a fact that vlc_object_find()
> is a hack, that has caused lots of bugs in the past, and continues to be
> indirectly responsible for a number of limitations.

Please mention such thoughts in future commit messages. :-)

> I'd actually rather people do not write _new_ code using it... so I am a bit
> mixed about this patch.

Originally I planned to add re-encoding support to the airtunes^Wraop
plugin, but have since abandoned this plan (the transcode module does
everything needed). I don't need vlc_object_find anymore, feel free to
drop the patch.

Regards,
Michael