[vlc-devel] commit: [QT] cosmetic, use regexp instead of multiple removes in simple preferences ( Ilkka Ollakka )

git version control git at videolan.org
Wed Dec 17 20:52:24 CET 2008


vlc | branch: 0.9-bugfix | Ilkka Ollakka <ileoo at videolan.org> | Mon Dec 15 13:48:22 2008 +0200| [d78b37ba0f530a0dc360acc7ead8da1616975f38] | committer: Jean-Baptiste Kempf 

[QT] cosmetic, use regexp instead of multiple removes in simple preferences
(cherry picked from commit b3da319e29b52d3849d0c3c33d1156a3e532fa67)

Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=d78b37ba0f530a0dc360acc7ead8da1616975f38
---

 modules/gui/qt4/components/simple_preferences.cpp |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/modules/gui/qt4/components/simple_preferences.cpp b/modules/gui/qt4/components/simple_preferences.cpp
index d196990..5132b43 100644
--- a/modules/gui/qt4/components/simple_preferences.cpp
+++ b/modules/gui/qt4/components/simple_preferences.cpp
@@ -693,10 +693,7 @@ void SPrefsPanel::apply()
                    that we have to remove */
                 if( !b_normChecked )
                 {
-                    /* Ugly :D */
-                    qs_filter.remove( "volnorm:" );
-                    qs_filter.remove( ":volnorm" );
-                    qs_filter.remove( "volnorm" );
+                    qs_filter.remove( QRegExp(":?volnorm:?") );
                 }
             }
             else /* qs_filter not empty, but doesn't have volnorm inside */




More information about the vlc-devel mailing list