[vlc-devel] [PATCH] Xiph metadata parsing update: Kate has Vorbis comments, CMML does not

ogg.k.ogg.k at googlemail.com ogg.k.ogg.k at googlemail.com
Fri Dec 19 18:59:12 CET 2008

> Then why is the parameter signed in the first place?

Because it's int all the way up to logical_stream_t, I gather.
Reading the code, it's also initialized from the 'bytes' field
from an ogg_packet, which is a long (so signed, and that
can have a larger range than just int, so bad things could
happen there too).
I think it's a mistake to have that as a long in the libogg API
in the first place, but...
Anyway, if this type change is done, it should probably be
a separate patch.

More information about the vlc-devel mailing list