[vlc-devel] [PATCH]Win32 fix raop.c compilation

Rémi Denis-Courmont rem at videolan.org
Sun Dec 21 10:29:08 CET 2008


Le dimanche 21 décembre 2008, Michael Hanselmann a écrit :
> 2008/12/20 Kaarlo Räihä <agent_007 at luukku.com>:
> > raop.c doesn't compile under Win32. This patch adds strsep function
> > to file itself. strsep should be in somewhere else and currently it
> > is missing from headers when you use Win32. So this patch isn't
> > pretty one, but because I am only interested about Win32
> > compilation, this is enough for me. (BTW raop.c is only file in VLC
> > that uses strsep function)
>
> I'm the original author of the RAOP plugin.
>
> We could change it to use strtok(), which is part of ISO C90 and more
> portable, but cannot handle empty fields (e.g. two separators
> together). After looking through the code again it seems an
> acceptable solution. I'll send a patch as soon as I find the time to
> make it.

AFAIK, strtok() is not thread-safe, in which case it is not an option 
for VLC.



-- 
Rémi Denis-Courmont
http://www.remlab.net/



More information about the vlc-devel mailing list