[vlc-devel] [PATCH] Have the function return a value, as it's a non-void function.

[Rémi Denis-Courmont]

Le lundi 22 décembre 2008, Dominique Leuenberger a écrit :
> diff --git a/modules/video_filter/atmo/atmo.cpp
> b/modules/video_filter/atmo/atmo.cpp index 7a9d02d..90c9091 100644
> --- a/modules/video_filter/atmo/atmo.cpp
> +++ b/modules/video_filter/atmo/atmo.cpp
> @@ -1825,6 +1825,7 @@ static void *FadeToColorThread(vlc_object_t
> *obj) /* call indirect to OleUnitialize() for this thread */
>      AtmoFinalize(p_fadethread->p_filter, 0);
>      vlc_restorecancel (canc);
> +    return VLC_SUCCESS;
>  }

You are now on my crap list, which means I won't be looking at any of 
your patch for a week. You are obviously not testing them (as in not 
even checking the compiler output).

-- 
Rémi Denis-Courmont
http://www.remlab.net/