[vlc-devel] commit: Fix a segfault when parsing meta data in ogg. ( Rémi Duraffort )

git version control git at videolan.org
Sat Dec 27 15:11:52 CET 2008


vlc | branch: master | Rémi Duraffort <ivoire at videolan.org> | Sat Dec 27 15:10:39 2008 +0100| [c93083157256930a2a0a582d016ab0e7baf7c545] | committer: Rémi Duraffort 

Fix a segfault when parsing meta data in ogg.
Thanks to Vincent Penquerc'h.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=c93083157256930a2a0a582d016ab0e7baf7c545
---

 include/vlc_meta.h |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/include/vlc_meta.h b/include/vlc_meta.h
index b5fc8c3..124b8ec 100644
--- a/include/vlc_meta.h
+++ b/include/vlc_meta.h
@@ -135,11 +135,8 @@ static inline void vlc_meta_AddExtra( vlc_meta_t *m, const char *psz_name, const
 {
     char *psz_oldvalue = (char *)vlc_dictionary_value_for_key( &m->extra_tags, psz_name );
     if( psz_oldvalue != kVLCDictionaryNotFound )
-    {
-        free( psz_oldvalue );
         vlc_dictionary_remove_value_for_key( &m->extra_tags, psz_name,
                                              vlc_meta_FreeExtraKey, NULL );
-    }
     vlc_dictionary_insert( &m->extra_tags, psz_name, strdup(psz_value) );
 }
 




More information about the vlc-devel mailing list