[vlc-devel] [PATCH] Changed snapshot naming format to be prefix-YYMMDD-HHmms.ext
ilkka.ollakka+vlc at oamk.fi
Mon Dec 29 15:00:00 CET 2008
On ma 29. joulukuuta 2008 15:24:25, basos g wrote:
> 2008/12/29 Rémi Denis-Courmont <rem at videolan.org>:
> > The use of stat() is quite silly, here. I believe two thread checking it
> > at about the same time, they'll use the same filename anyhow.
> This is to account for the case that snapshots are taken at a rate
> higher than 1 per second. It assures that not snap will be lost due to
> fast snap rate or even (but less possible) for filenames that already
> exists ...
> I considered it an issue and i would implement it that way. If you
> don't i won't pose another veto, though...
Wouldn't it be better to use something like pic->date as extra postfix
instead of that incrementation counting, and that way you shuold get
more easily unique filename (not whole date, but part of it, as it's
done in original code)
Travel important today; Internal Revenue men arrive tomorrow.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 197 bytes
Desc: not available
More information about the vlc-devel