[vlc-devel] [PATCH] Changed snapshot naming format to be prefix-YYMMDD-HHmms.ext

[basos g]

2008/12/29 basos g <noxelia at gmail.com>:
> 2008/12/29 Ilkka Ollakka <ilkka.ollakka+vlc at oamk.fi>:
>> On ma 29. joulukuuta 2008 15:24:25, basos g wrote:
>>> 2008/12/29 Rémi Denis-Courmont <rem at videolan.org>:
>>> > The use of stat() is quite silly, here. I believe two thread checking it
>>> > at about the same time, they'll use the same filename anyhow.
>>> >
>>>
>>> This is to account for the case that snapshots are taken at a rate
>>> higher than 1 per second. It assures that not snap will be lost due to
>>> fast snap rate or even (but less possible) for filenames that already
>>> exists ...
>>>
>>> I considered it an issue and i would implement it that way. If you
>>> don't i won't pose another veto, though...
>>
>> Wouldn't it be better to use something like pic->date as extra postfix
>> instead of that incrementation counting, and that way you shuold get
>> more easily unique filename (not whole date, but part of it, as it's
>> done in original code)
>
> That;s good idea. I implemented it avoiding to stat() and making it
> impossible for two snaps that are no closer than 1/10th of second to
> have the same name..
>
> Last commit ?? ( Ok, i forget some thingys, sometimes...)
>

Another thingy ...A remnand from the stat that caused a warning.. Last.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-Mod-Changed-snapshot-naming-format-to-be-prefix-YY.patch
Type: text/x-diff
Size: 3100 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20081229/6e70e4f2/attachment.patch>