[vlc-devel] commit: Qt: release input sooner (Jean-Baptiste Kempf )

git version control git at videolan.org
Wed Dec 31 13:44:17 CET 2008


vlc | branch: master | Jean-Baptiste Kempf <jb at videolan.org> | Wed Dec 31 13:32:30 2008 +0100| [969e7a010d45430be7e6f21ab266a24017b268d6] | committer: Jean-Baptiste Kempf 

Qt: release input sooner

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=969e7a010d45430be7e6f21ab266a24017b268d6
---

 modules/gui/qt4/input_manager.cpp |   17 ++++++++---------
 1 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/modules/gui/qt4/input_manager.cpp b/modules/gui/qt4/input_manager.cpp
index 1bcb084..cd265df 100644
--- a/modules/gui/qt4/input_manager.cpp
+++ b/modules/gui/qt4/input_manager.cpp
@@ -114,6 +114,9 @@ void InputManager::delInput()
     timeA                = 0;
     timeB                = 0;
 
+    vlc_object_release( p_input );
+    p_input = NULL;
+
     emit positionUpdated( -1.0, 0 ,0 );
     emit rateChanged( INPUT_RATE_DEFAULT ); /* TODO: Do we want this ? */
     emit nameChanged( "" );
@@ -121,18 +124,14 @@ void InputManager::delInput()
     emit titleChanged( 0 );
     emit statusChanged( END_S );
 
-    /* Reset InfoPanels but stats */
-    emit artChanged( NULL );
-    emit infoChanged( NULL );
-    emit metaChanged( NULL );
-
     emit teletextPossible( false );
-    emit voutChanged( false );
-
     emit AtoBchanged( false, false );
-    vlc_object_release( p_input ); /* FIXME: Can't we release sooner ? */
+    emit voutChanged( false );
 
-    p_input = NULL;
+    /* Reset all InfoPanels but stats */
+    emit artChanged( NULL );
+    emit infoChanged( NULL );
+    emit metaChanged( NULL );
 }
 
 /* Add the callbacks on Input. Self explanatory */




More information about the vlc-devel mailing list