[vlc-devel] commit: test if access dc1394 is right earlier in the probing process to avoid side effect (irrelevant errors) for others. (Joseph Tulou )

git version control git at videolan.org
Wed Dec 31 13:53:52 CET 2008


vlc | branch: master | Joseph Tulou <brezhoneg1 at yahoo.fr> | Tue Dec 30 15:34:00 2008 +0100| [950a8cc26193f2512f5d1b5efd0a0ca49f5ca23d] | committer: Jean-Paul Saman 

test if access dc1394 is right earlier in the probing process to avoid side effect (irrelevant errors) for others.

Signed-off-by: Jean-Paul Saman <jpsaman at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=950a8cc26193f2512f5d1b5efd0a0ca49f5ca23d
---

 THANKS                  |    1 +
 modules/access/dc1394.c |    6 +++---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/THANKS b/THANKS
index 84934b9..ef87288 100644
--- a/THANKS
+++ b/THANKS
@@ -137,6 +137,7 @@ Jean-François Massol <jf.massol -<@t> gmail.com> - Qt4 Sout work
 Jérôme Guilbaud - Update of the WinAmp 5 VLC skin
 Joel Arvidsson <dogai at privat.utfors.se> - Swedish translation
 Joeri van Dooren <joeri at van.dooren.be> - OS X icon (v0.4.0)
+Joseph Tulou <brezhoneg1 at yahoo.fr> - small dc1394 patch
 Jörg<vlc-ml at aab.noctis dot de> - VLM seek/show media functions
 Johannes Buchner <buchner.johannes at gmx dot at> - Hotkeys for zoom
 Johen Michael Zorko <zorko at att.net> - fix for delay issues in udp sout
diff --git a/modules/access/dc1394.c b/modules/access/dc1394.c
index 18ad44d..9fa05aa 100644
--- a/modules/access/dc1394.c
+++ b/modules/access/dc1394.c
@@ -218,6 +218,9 @@ static int Open( vlc_object_t *p_this )
     int i_aspect;
     int result = 0;
 
+    if( strncmp(p_demux->psz_access, "dc1394", 6) != 0 )
+        return VLC_EGENERIC;
+
     /* Set up p_demux */
     p_demux->pf_demux = Demux;
     p_demux->pf_control = Control;
@@ -834,9 +837,6 @@ static int process_options( demux_t *p_demux )
     char *state = NULL;
     float rate_f;
 
-    if( strncmp(p_demux->psz_access, "dc1394", 6) != 0 )
-        return VLC_EGENERIC;
-
     psz_dup = strdup( p_demux->psz_path );
     psz_parser = psz_dup;
     for( token = strtok_r( psz_parser,":",&state); token;




More information about the vlc-devel mailing list