[vlc-devel] vlc: svn commit r25381 (funman)

Laurent Aimar fenrir at via.ecp.fr
Fri Feb 29 20:28:04 CET 2008


On Fri, Feb 29, 2008, Rafaël Carré wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Rémi Denis-Courmont a écrit :
> > Le Wednesday 27 February 2008 21:46:32 Subversion daemon, vous avez écrit :
> >> r25381 | funman | 2008-02-27 20:46:31 +0100 (Wed, 27 Feb 2008) | 2 lines
> >> Changed paths:
> >>    M /trunk/src/input/stream.c
> >>
> >> fix #1404
> > 
> > This seems to be somewhat of a revert of [24790]. I don't know which commit is 
> > right or wrong, but can someone triple check?
> > 
> 
> I think [24790] is wrong, because it tries to fill the buffers when the
> exact end of the file has been reached already.
 In fact it was the wanted behaviour to detect end of file when seeking
exactly at the end (it is done the same way with stream mode iof block).

 Reverting [24790] just broke access that use pf_block() mode (like mapped
file).

 What problem do you have with it ?

-- 
fenrir




More information about the vlc-devel mailing list