[vlc-devel] [PATCH] G.711 RTP payload for Stream Input

[Rémi Denis-Courmont]

	Hello,

Le vendredi 4 janvier 2008, maurizio simoni a écrit :
> I've modified latest VLC sources from trunk (vlc-0.9.0) to add PCMU
> and PCMA as new demux modules. In this way it's possible to play RTP
> streams with G.711, both alaw and ulaw.
> In attachment there is the related patch.

As Christophe pointed out, there should probably be a single PCM demux 
plugin. I believe you can read p_demux->psz_demux from the Open() 
callback to determine your "name". In fact, this could easily be 
extended to L8 and L16 payload types, and probably any other 
sample-based audio codec.

Generally speaking, VLC should already be capable of receiving G.711 
through the live555 access_demux plugin, if it's fed an appropriate 
SDP. There are reasons why someone would not want to use a SDP (though 
this can only work for static RTP payload types) or not want to use 
Live555, so I am not objecting.

I think the real problem is an architectural bug in VLC, whereby RTP 
handling should be done in a demux, not in the UDP access plugin 
though. Maybe someday I'll get round to fixing this. In the mean time, 
please fix your patch following the Christophe's comments, so we can 
merge it.

Thanks,

-- 
Rémi Denis-Courmont
http://www.remlab.net/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080105/7cf1b435/attachment.sig>