[vlc-devel] Patch to enable H264 playback on iPhones.

[Jean-Paul Saman]

Christopher Key wrote:
> Hello,
> 
> Attached is a patch that fixes a long standing problem whereby video 
> encoded with vlc using x264 cannot be made playable on an iPhone.  The 
> issue was traced to the H264 profile value being incorrectly set, which 
> this patch addresses.  Looking at the code, the trunk appears to have 
> had a complete rewrite and should be unaffected, but this may be useful 
> for a 0.8.6e release.
> 
> Regards,
> 
> Chris
> 
> --- vlc-0.8.6d/modules/mux/mp4.c.orig   2007-11-26 13:08:07.000000000 +0000
> +++ vlc-0.8.6d/modules/mux/mp4.c        2008-01-08 01:59:50.000000000 +0000
> @@ -723,7 +723,7 @@
>              memcpy( tk->avc.sps, &last[4], i_size );
> 
>              tk->avc.i_profile = tk->avc.sps[1];
> -            tk->avc.i_profile = tk->avc.sps[2];
> +            tk->avc.i_profile_compat = tk->avc.sps[2];
>              tk->avc.i_level   = tk->avc.sps[3];
>          }
>          else if( (last[4]&0x1f) == 8 && tk->avc.i_pps <= 0 )   /* PPS */
> 

  Could you also test vlc-trunk behaviour for the iPhone, please ?

Gtz
Jean-Paul Saman.