[vlc-devel] [PATCH] Writing string settings to VLC config

Andrew Zaikin andrew.zaikin at gmail.com
Thu Jan 10 13:42:14 CET 2008

In fact there is another problem just 2 lines below:
*if (b_retain) break;*
It used to be inside *switch{} *block, so break was intended to get out of
switch. During http://trac.videolan.org/vlc/changeset/23654 switch was
eliminated, so now break interrupt *for{}*. For the user it looks like when
VLC is when you are saving preferences from the corresponding window - it
works fine, but when you are close VLC and it does automatic save, it stops
the process after saving first string setting for each section. Attached is
cumulative patch that fixes both problems.

On Jan 9, 2008 5:28 PM, Andrew Zaikin <andrew.zaikin at gmail.com> wrote:

> 4th parameter of *config_Write()* called *comment* and determine whenever
> setting will be prefixed by "#" in config file
> All occurrence of *config_Write() *except patched treat this parameter as
> "is value remains the same", but for strings we are passing value of *
> modified* variable which is logical inversion.
> So it looks like we were writing string values, that was non-modified and
> commenting modified
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080110/ced4fc5f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: config_fix.patch
Type: application/octet-stream
Size: 1437 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080110/ced4fc5f/attachment.obj>

More information about the vlc-devel mailing list