[vlc-devel] commit: Fix NULL dereference before NULL check (CID #119) ( Rémi Denis-Courmont )

[git version control]

vlc | branch: 0.8.6-bugfix | Rémi Denis-Courmont <rdenis at simphalempin.com> | Tue Jul  1 23:35:38 2008 +0300| [0710c61cffc157456e7557d3be3b0e1b974e9f61]

Fix NULL dereference before NULL check (CID #119)

And guess what? it was tagged a FALSE positive.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=0710c61cffc157456e7557d3be3b0e1b974e9f61
---

 modules/stream_out/transcode.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/modules/stream_out/transcode.c b/modules/stream_out/transcode.c
index 4fdbd0c..c218bc4 100644
--- a/modules/stream_out/transcode.c
+++ b/modules/stream_out/transcode.c
@@ -2801,7 +2801,7 @@ static void transcode_osd_close( sout_stream_t *p_stream, sout_stream_id_t *id)
     /* Close encoder */
     if( id )
     {
-        if( id->p_encoder->p_module )
+        if( id->p_encoer && id->p_encoder->p_module )
             module_Unneed( id->p_encoder, id->p_encoder->p_module );
 
         if( id->id ) p_sys->p_out->pf_del( p_sys->p_out, id->id );