[vlc-devel] commit: Remove hacking fullscreen control invocation - fixes #1653 ( Rémi Denis-Courmont )

[Lukas Durfina]

On Wed, 02 Jul 2008 20:25:45 +0200, git version control <git at videolan.org>  
wrote:

> vlc | branch: master | Rémi Denis-Courmont <rdenis at simphalempin.com> |  
> Wed Jul  2 21:26:12 2008 +0300|  
> [fee80aa4d5f3339153cf0d2f875fc5ef10f873ff]
>
> Remove hacking fullscreen control invocation - fixes #1653

I looked at this ticket, and I think it can be solved by
other way than disabling fs controller at all.
Maybe some better backtrace. FS controller can clean up
only callbacks (what I didnt do, because they were deleted
with video output), can undelete callbacks caused that crash?

>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=fee80aa4d5f3339153cf0d2f875fc5ef10f873ff
> ---
>
>  modules/gui/qt4/main_interface.cpp |    7 -------
>  1 files changed, 0 insertions(+), 7 deletions(-)
>
> diff --git a/modules/gui/qt4/main_interface.cpp  
> b/modules/gui/qt4/main_interface.cpp
> index fda96ff..4fdde6d 100644
> --- a/modules/gui/qt4/main_interface.cpp
> +++ b/modules/gui/qt4/main_interface.cpp
> @@ -683,17 +683,10 @@ void *MainInterface::requestVideo( vout_thread_t  
> *p_nvout, int *pi_x,
> //        emit askVideoToResize( *pi_width, *pi_height );
>          emit askUpdate();
> -
> -        fullscreenControls->regFullscreenCallback( p_nvout );
>      }
>      return ret;

why is this considered as hack?


>  }
> -void MainInterface::requestNotEmbeddedVideo( vout_thread_t *p_nvout )
> -{
> -    fullscreenControls->regFullscreenCallback( p_nvout );
> -}
> -

this is not used anyway, so good idea to remove