[vlc-devel] [PATCH]OpenGL video output colorspace correction

Antoine Cellerier dionoea at videolan.org
Sun Jul 6 17:26:25 CEST 2008


On Sun, Jul 06, 2008, Kaarlo Räihä wrote:
> Someone pointed out that OpenGL video output swaps red and blue components in nightlies
> http://forum.videolan.org/viewtopic.php?f=14&t=47935&start=0&st=0&sk=t&sd=a
> I checked with Vista+Nvidia and XP+ATI to make sure it isn't driver or OS related issues.
> 
> I don't know what has caused this issue (in 0.8.6 it works without this) but at least this patch fixes it under Windows. Patch should affect to Linux/Unix also (I don't have GUI box to check it out), so please someone check if it does break Linux/Unix OpenGL. If it does, you can fix it by making sure that Linux/Unix uses
> 
> #define VLCGL_FORMAT VLCGL_RGB_FORMAT
> #define VLCGL_TYPE   VLCGL_RGB_TYPE
> 
> 
> Because of GL_BGRA, the output should work little faster under Windows but difference is minimal.
> http://www.gamedev.net/community/forums/topic.asp?topic_id=327540

Must be somehow linked to:
https://trac.videolan.org/vlc/ticket/1659
Could you try changing the chroma mapping in swscale to check? (Change
it from PIX_FMT_RGB24 to PIX_FMT_BGR24) Or are you using on of the VLC
internal chroma conversion modules?

-- 
Antoine Cellerier
dionoea



More information about the vlc-devel mailing list