[vlc-devel] commit: messages: Prefer the object name over the object type if type is VLC_GENERIC. ( Pierre d'Herbemont )

[Pierre d'Herbemont]

On Jul 6, 2008, at 6:10 PM, Rémi Denis-Courmont wrote:

> Le dimanche 6 juillet 2008 18:39:22 git version control, vous avez  
> écrit :
>> vlc | branch: master | Pierre d'Herbemont  
>> <pdherbemont at videolan.org> | Sun
>> Jul  6 16:57:51 2008 +0200|  
>> [0386618539878fde94110df15b77ba7c79e54e8c]
>>
>> messages: Prefer the object name over the object type if type is
>> VLC_GENERIC.
>
> Hmm err, that sucks IMHO. psz_object_type normally contains something
> meaningful (psz_objet_type != i_type), and when not (i.e. when
> vlc_object_create is called from a plugin), then MODULE_NAME is  
> already
> specified as the first parameter.

Well, not everytime, for instance with the preparser and the fetcher,  
or vlm.

The only object to have (psz_objet_type != i_type) is the "http server".

> Now I get stupid looking messages like:
> [00000331] access_mmap access_mmap debug: at end of memory mapped file
> [00000336] playlist playlist debug: parsed 0 tracks successfully

Hum. Embarrassing.

I think I'll revert, and fix the object type.

But then, what's the difference between object_name and object_type?

Pierre.