[vlc-devel] [PATCH] Fix fs controller

[Lukas Durfina]

On Fri, 04 Jul 2008 22:53:26 +0200, Rémi <Denis-Courmont"  
<rdenis at simphalempin.com>> wrote:

>
> static variables suck, especially when they're not protected against

I agree, I made new version without static

> concurrent access. And then, I wonder if the actual fullscreen controller
> code is thread-safe at all.

do you mean some part of fullscreen controller or only initialization?
I know initialization is problematic piece of code. Now creation of  
variable
should be fine and be done early enough before creation of vout or  
interface.
But I need to solve problem with registering callback, and I would really  
appreciate
help to make it (thread-)safe.
I need to solve case, when variable "new-vout" is set before registering  
callback,
it is done from another thread, so somtimes on startup it is set before  
interface
creation. How can I set it correctly? by locking? For example when I  
register
callback and find out, that variable was set before, I will set it again  
to invoke
callback?

Or I will make it in old way, when it is called from MainInterface,
that would be safe, but it doesnt work for nonembedded video.
It would be temporary solution for have at least some fs controller.

Lukas


-------------- next part --------------
A non-text attachment was scrubbed...
Name: fs_controller3.diff
Type: application/octet-stream
Size: 4685 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080707/abcb70e2/attachment.obj>