[vlc-devel] commit: vout: use vlc_custom_create ( Rémi Denis-Courmont )

[Bill C. Riemers]

Never mind.   After running "make distclean" a second time I am getting
a completely different compile error.  I am not sure if this cleared
this error, or I am no longer getting to the compile step that caused it.

Bill

Bill C. Riemers wrote:
> I am guessing this commit is responsible for the undefined reference to
> vlc_custom_create.
>
> gcc -std=gnu99 -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith
> -Wbad-function-cast -Wcast-align -Wwrite-strings -Wmissing-prototypes
> -Wvolatile-register-var -o vlc vlc-vlc.o -g  ./.libs/libvlc.so
> /autohome/docbill/source/git/vlc/src/.libs/libvlccore.so -L/lib64
> ./.libs/libvlccore.so -lhal -ldbus-1 -lrt -lpthread -ldl -lm 
> -Wl,--rpath -Wl,/autohome/docbill/source/git/vlc/src/.libs
> /autohome/docbill/source/git/vlc/src/.libs/libvlccore.so: undefined
> reference to `vlc_custom_create'
> ./.libs/libvlc.so: undefined reference to `__vlc_object_alive'
> collect2: ld returned 1 exit status
>
>
>
> git version control wrote:
>   
>> vlc | branch: master | Rémi Denis-Courmont <rdenis at simphalempin.com> | Sat Jun 28 21:22:24 2008 +0300| [2d7ef1f4bb145fd0ea210edefd32f60e2eabb214]
>>
>> vout: use vlc_custom_create
>>
>>   
>>     
>>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=2d7ef1f4bb145fd0ea210edefd32f60e2eabb214
>>>     
>>>       
>> ---
>>
>>  src/misc/objects.c              |    4 ----
>>  src/video_output/video_output.c |    4 +++-
>>  2 files changed, 3 insertions(+), 5 deletions(-)
>>
>> diff --git a/src/misc/objects.c b/src/misc/objects.c
>> index c4b79ed..fd9e413 100644
>> --- a/src/misc/objects.c
>> +++ b/src/misc/objects.c
>> @@ -250,10 +250,6 @@ void * __vlc_object_create( vlc_object_t *p_this, int i_type )
>>              i_size = sizeof(filter_t);
>>              psz_type = "filter";
>>              break;
>> -        case VLC_OBJECT_VOUT:
>> -            i_size = sizeof(vout_thread_t);
>> -            psz_type = "video output";
>> -            break;
>>          case VLC_OBJECT_AOUT:
>>              i_size = sizeof(aout_instance_t);
>>              psz_type = "audio output";
>> diff --git a/src/video_output/video_output.c b/src/video_output/video_output.c
>> index eb64a3e..ff29b27 100644
>> --- a/src/video_output/video_output.c
>> +++ b/src/video_output/video_output.c
>> @@ -243,7 +243,9 @@ vout_thread_t * __vout_Create( vlc_object_t *p_parent, video_format_t *p_fmt )
>>      char *psz_name;
>>  
>>      /* Allocate descriptor */
>> -    p_vout = vlc_object_create( p_parent, VLC_OBJECT_VOUT );
>> +    static const char typename[] = "video output";
>> +    p_vout = vlc_custom_create( p_parent, sizeof( *p_vout ), VLC_OBJECT_VOUT,
>> +                                typename );
>>      if( p_vout == NULL )
>>          return NULL;
>>  
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> http://mailman.videolan.org/listinfo/vlc-devel
>>   
>>     
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>