[vlc-devel] [PATCH] [contrib/liboil] invalid code is produced on osx/ppc without -O2

[David Flynn]

From: Jonathan Rosser <jrosser at rd.bbc.co.uk>
Date: Tue, 15 Jul 2008 12:41:32 +0100

Specifying any CFLAGS clobbers any that liboil's configure script would
naturally choose.  With only an effective -O0 gcc 4.0.1 doesn't produce
code as intented for copy_u8_altivec, causing liboil to fail at runtime.

Summary, liboil really needs -O2 (always).

Signed-off-by: David Flynn <davidf at rd.bbc.co.uk>
---
 extras/contrib/src/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/extras/contrib/src/Makefile b/extras/contrib/src/Makefile
index 26d5be0..8715a95 100644
--- a/extras/contrib/src/Makefile
+++ b/extras/contrib/src/Makefile
@@ -2428,7 +2428,7 @@ liboil: liboil-$(OIL_VERSION).tar.gz
 	patch -d liboil -p1 < Patches/liboil-noshared.patch
 
 .liboil: liboil
-	(cd $<; $(HOSTCC) ./configure $(HOSTCONF) --prefix=$(PREFIX) && make && make install)
+	(cd $<; $(HOSTCC) ./configure $(HOSTCONF) --prefix=$(PREFIX) CFLAGS="$(CFLAGS) -O2" && make && make install)
 	touch $@
 
 CLEAN_FILE += .liboil
-- 
1.5.5