[vlc-devel] commit: interaction: Fix a interaction leak. (Pierre d'Herbemont )

git version control git at videolan.org
Tue Jul 15 19:31:49 CEST 2008


vlc | branch: master | Pierre d'Herbemont <pdherbemont at videolan.org> | Tue Jul 15 19:24:55 2008 +0200| [7e97924ce74631403452a8b9652c309d65946d9c]

interaction: Fix a interaction leak.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=7e97924ce74631403452a8b9652c309d65946d9c
---

 src/interface/interaction.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/src/interface/interaction.c b/src/interface/interaction.c
index 633ea49..e0920ea 100644
--- a/src/interface/interaction.c
+++ b/src/interface/interaction.c
@@ -474,7 +474,11 @@ static int DialogSend( vlc_object_t *p_this, interaction_dialog_t *p_dialog )
     if( p_dialog->i_id == 0 )
         p_dialog->i_id = ++p_interaction->i_last_id;
 
-    if( p_this->i_flags & OBJECT_FLAGS_NOINTERACT ) return VLC_EGENERIC;
+    if( p_this->i_flags & OBJECT_FLAGS_NOINTERACT )
+    {
+        vlc_object_release( p_interaction );
+        return VLC_EGENERIC;
+    }
 
     if( config_GetInt( p_this, "interact" ) ||
         p_dialog->i_flags & DIALOG_BLOCKING_ERROR ||




More information about the vlc-devel mailing list