[vlc-devel] commit: Remove non-sensical NPT computation code from c9569b35. ( Rémi Denis-Courmont )

[Pierre d'Herbemont]

On Jul 21, 2008, at 3:13 AM, Derk-Jan Hartman wrote:

> On 10 jul 2008, at 02:04, Ross Finlayson wrote:
>>> vlc | branch: master | Rémi Denis-Courmont  
>>> <rdenis at simphalempin.com> | Wed Jul  9 22:52:21 2008 +0300|  
>>> [64417a25b912edb125c8a06c1f028115ba504eef]
>>>
>>> Remove non-sensical NPT computation code from c9569b35.
>>>
>>> If you want RTSP time, please come up with an algorithm that makes  
>>> some
>>> kind of sense. In the mean, it's better not to claim to support
>>> somethign we don't support.
>>
>> I remind people of the following, which I originally posted back in  
>> January:
> <cut>
>>> Note, in particular, the definition of
>>>        MediaSubsession::getNormalPlayTime()
>>> in "liveMedia/include/MediaSession.hh".
> <cut>
>
> I've being doing some work on the live555 code, because it was in a  
> dismal state. partially caused by my absence last year.
> I have attached a patch that has many of my proposed changes.
>
> This tackles several issues:
> 1: removes all LIVEMEDIA version checks. It's about time we force  
> another update here. Versions from this year are much better
>   (P.S. Ross, do you have a recent VERSION_INT from the last "API  
> change" ? )
> 2: add support for NPT and also DEMUX_GET_TIME DEMUX_SET_TIME based  
> on these.
> 3: fixes 461 Unsupported transport fallback, that was broken in the  
> recent "force-mcast" patch [175310ff6066991ee45e2a839f8c53e12b75e6d4]
> 4: fixes RollOverTcp no-data timeout on TCP data. broken in  
> [fed83de55cdaf7f623a16f1051d97d450c44ad63]
> 5: re-add DEMUX_GET_POSITION (now based on NPT, not on PTS)
> 6: cleanup initialized ES when we do the SETUPS again in RollOverTcp
> 7: fix RollOverTcp re-sending of Connect()
> 8: Some other pts/pcr cleanup
> 9: removal of startseq code (no longer needed due to  
> getNormalPlayTime() )
>
> I will try to split these changes as much as possible when i commit,  
> i just wanted to show everyone what I was working on, and give  
> people the opportunity to test and give feedback.

What about doing that in a custom public repo until this is stable  
enough to be merged?

Pierre.