[vlc-devel] commit: don't release before unlock, thanks to ivoire for spotting this ( Ilkka Ollakka )

git version control git at videolan.org
Wed Jul 23 14:39:50 CEST 2008


vlc | branch: master | Ilkka Ollakka <ileoo at videolan.org> | Wed Jul 23 15:42:08 2008 +0300| [858fa11f2d5f8194f7cecaf94b6a0844db190915]

don't release before unlock, thanks to ivoire for spotting this

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=858fa11f2d5f8194f7cecaf94b6a0844db190915
---

 modules/misc/lua/libs/playlist.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/modules/misc/lua/libs/playlist.c b/modules/misc/lua/libs/playlist.c
index 067e300..9dfe97c 100644
--- a/modules/misc/lua/libs/playlist.c
+++ b/modules/misc/lua/libs/playlist.c
@@ -246,8 +246,8 @@ static int vlclua_playlist_get( lua_State *L )
         p_item = playlist_ItemGetById( p_playlist, i_id, true );
         if( !p_item )
         {
-            vlclua_release_playlist_internal( p_playlist );
             vlc_object_unlock( p_playlist );
+            vlclua_release_playlist_internal( p_playlist );
             return 0; /* Should we return an error instead? */
         }
     }




More information about the vlc-devel mailing list