[vlc-devel] commit: Revert "Fix #1761: open directory plays." (Jean-Baptiste Kempf )

[Pierre d'Herbemont]

On Jul 26, 2008, at 6:53 PM, git version control wrote:

> vlc | branch: master | Jean-Baptiste Kempf <jb at videolan.org> | Sat  
> Jul 26 09:52:31 2008 -0700| [566b2803ca089a3564a080da8f45e01480ed7e91]
>
> Revert "Fix #1761: open directory plays."
>
> This reverts commit 84091c6692d4e22e6082ecf692c4df6e9e292b2f.
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=566b2803ca089a3564a080da8f45e01480ed7e91
> ---
>
> modules/gui/qt4/dialogs_provider.cpp |    5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/modules/gui/qt4/dialogs_provider.cpp b/modules/gui/qt4/ 
> dialogs_provider.cpp
> index 758ebec..98d11ab 100644
> --- a/modules/gui/qt4/dialogs_provider.cpp
> +++ b/modules/gui/qt4/dialogs_provider.cpp
> @@ -356,15 +356,14 @@ static void openDirectory( intf_thread_t  
> *p_intf, bool pl, bool go )
>         playlist_AddInput( THEPL, p_input,
>                        go ? ( PLAYLIST_APPEND | PLAYLIST_GO ) :  
> PLAYLIST_APPEND,
>                        PLAYLIST_END, pl, pl_Unlocked );
> -        /* Why this ?
> -         * input_Read( THEPL, p_input, false ); */
> +        input_Read( THEPL, p_input, false );

As you noted, it is certainly a bad idea, not to leave the playlist do  
that by itself. Why don't you just remove it? (And add something like  
AUTOPLAY, OR_WTF_ITS_NAMED ;) )