[vlc-devel] commit: avformat: do away with strang stream_Tell >= stream_Size check. ( Derk-Jan Hartman )

[Derk-Jan Hartman]

On 30 jul 2008, at 10:38, Rémi Denis-Courmont wrote:

> On Wednesday 30 July 2008 04:31:08 git version control, you wrote:
>> vlc | branch: master | Derk-Jan Hartman <hartman at videolan.org> |  
>> Wed Jul 30
>> 03:32:35 2008 +0200| [b5c566d923f2dc68e03a6e8deacfc5607982f27a]
>>
>> avformat: do away with strang stream_Tell >= stream_Size check.
>
> Hmm, what if the file size changes dynamically? (yes, this *can*  
> happen)

Then that still isn't the EOF for the file is it ? At most, it means  
the stream_Size we had been using is no longer valid at that point,  
but the Seek should be no problem (and will still return -1 if it does  
seek past the end). I'm not so sure how well avformat supports files  
that change size, but I don't think we should set EOF for this case.

DJ