[vlc-devel] commit: Fix segfault in sap service discovery. ( Rémi Duraffort )

[Pierre d'Herbemont]

Quoting git version control <git at videolan.org>:

> vlc | branch: master | Rémi Duraffort <ivoire at videolan.org> | Thu Jul 31
> 11:15:53 2008 +0200| [d7a21b12e9dc5e883e2401faa817fdf211372626]
>
> Fix segfault in sap service discovery.
>
> >
>
http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=d7a21b12e9dc5e883e2401faa817fdf211372626
> ---
>
>  modules/services_discovery/sap.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/modules/services_discovery/sap.c
> b/modules/services_discovery/sap.c
> index 6dfadf5..d0d1144 100644
> --- a/modules/services_discovery/sap.c
> +++ b/modules/services_discovery/sap.c
> @@ -547,10 +547,8 @@ static void Run( services_discovery_t *p_sd )
>
>      psz_addr = var_CreateGetString( p_sd, "sap-addr" );
>      if( psz_addr && *psz_addr )
> -    {
>          InitSocket( p_sd, psz_addr, SAP_PORT );
> -        free( psz_addr );
> -    }
> +    free( psz_addr );

How can this fix a segfault? :) I guess you meant a mem leak?

Pierre.