[vlc-devel] commit: Usefull coment instead of "Gruik" (evenif I like the previous one.. .) ( Rémi Duraffort )

Laurent Aimar fenrir at via.ecp.fr
Thu Jul 31 20:31:50 CEST 2008


On Thu, Jul 31, 2008, git version control wrote:
> vlc | branch: master | Rémi Duraffort <ivoire at videolan.org> | Thu Jul 31 19:53:33 2008 +0200| [9589813471d0f5525789b7cf7165e48d177cbad6]
> 
> Usefull coment instead of "Gruik" (evenif I like the previous one...)
> 
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=9589813471d0f5525789b7cf7165e48d177cbad6
> ---
> 
>  modules/services_discovery/podcast.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/modules/services_discovery/podcast.c b/modules/services_discovery/podcast.c
> index 8d73270..5819b4e 100644
> --- a/modules/services_discovery/podcast.c
> +++ b/modules/services_discovery/podcast.c
> @@ -155,8 +155,9 @@ static void Run( services_discovery_t *p_sd )
>  {
>      services_discovery_sys_t *p_sys  = p_sd->p_sys;
>  
> +    /* Launch the callback associated with this variable */
>      char *psz_urls = var_CreateGetString( p_sd, "podcast-urls" );
var_CreateGetString will not launch any callbacks, it will just do the
inherit thing.

I think it can safely be replaced by
 var_Create( p_sd, "podcast-urls", VLC_VAR_STRING | VLC_VAR_DOINHERIT );
if you prefer (look at vlc_variables.h)

-- 
fenrir



More information about the vlc-devel mailing list