[vlc-devel] commit: Fix memory leak (CID 92) ( Rémi Denis-Courmont )

Pierre d'Herbemont pdherbemont at free.fr
Mon Jun 2 12:48:50 CEST 2008

On Jun 2, 2008, at 11:49 AM, Dominique Leuenberger wrote:

> Quoting git version control <git at videolan.org>:
>> vlc | branch: 0.8.6-bugfix | Rémi Denis-Courmont
>> <rdenis at simphalempin.com> | Sat May 31 23:19:32 2008 +0300|
>> [bd6877f9e3e0738013521bc98fe6bd12697a59ce]
>> +        goto error;
> WOW! And I thought the times of 'goto' are over for good. I've seen
> that you can use it twice.. but is this sacrifice really worthy?

Well, goto are not over for good, especially in C.

In that precise use it is the most appropriate and common in C code.  
Don't worry, it is being used wisely.

But you can try to look for goto abuse in VLC code if you like :)


More information about the vlc-devel mailing list