[vlc-devel] commit: Remove dead autoconf tests ( Rafaël Carré )

[Rafaël Carré]

2008/6/3 Pierre d'Herbemont <pdherbemont at free.fr>:
>
> On Jun 3, 2008, at 8:28 AM, git version control wrote:
>
>> vlc | branch: master | Rafaël Carré <funman at videolan.org> | Tue Jun
>> 3 01:50:37 2008 +0200| [e81f8e4ca21f28b3449b8922b6b81e12c1e56a4b]
>>
>> Remove dead autoconf tests
>>
>>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=e81f8e4ca21f28b3449b8922b6b81e12c1e56a4b
>> ---
>>
>> configure.ac |  226
>> ----------------------------------------------------------
>> 1 files changed, 0 insertions(+), 226 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 889e203..1b72e10 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -1015,16 +1015,6 @@ if test "${ac_cv_c_omit_frame_pointer}" !=
>> "no"; then
>>     CFLAGS_OPTIM_NODEBUG="${CFLAGS_OPTIM_NODEBUG} -fomit-frame-
>> pointer"
>> fi
>>
>> -dnl Check for -mdynamic-no-pic
>> -dnl AC_CACHE_CHECK([if \$CC accepts -mdynamic-no-pic],
>> -dnl     [ac_cv_c_dynamic_no_pic],
>> -dnl     [CFLAGS="${CFLAGS_save} -mdynamic-no-pic"
>> -dnl      AC_TRY_COMPILE([],,ac_cv_c_dynamic_no_pic=yes,
>> ac_cv_c_dynamic_no_pic=no)])
>> -dnl AS_IF([test "${ac_cv_c_dynamic_no_pic}" != "no"], [
>> -dnl     VLC_ADD_CFLAGS([builtin],[-mdynamic-no-pic])
>> -dnl     VLC_ADD_CFLAGS([libvlc],[-mdynamic-no-pic])
>> -dnl ])
>
> This one looks suspicious. -mdynamic-no-pic is used on darwin to
> produce optimized non-pic code for non shared library. You could
> probably turn that on by default on darwin target, or only check for
> it if we are building for darwin.

Look carefully for the "dnl" prefix in just every line I removed.
This particular test had been disabled for one year.

> Pierre.

-- 
Rafaël Carré