[vlc-devel] commit: Don't workaround unknown bugs in external libraries ( Rafaël Carré )

git version control git at videolan.org
Thu Jun 5 15:30:16 CEST 2008


vlc | branch: master | Rafaël Carré <funman at videolan.org> | Thu Jun  5 15:31:02 2008 +0200| [26716258739260ba9c3ffbe0d1e78509635abda2]

Don't workaround unknown bugs in external libraries

Better comment them fully, if you are too lazy to report upstream

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=26716258739260ba9c3ffbe0d1e78509635abda2
---

 modules/codec/ffmpeg/video.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/modules/codec/ffmpeg/video.c b/modules/codec/ffmpeg/video.c
index 3e380bb..12391a0 100644
--- a/modules/codec/ffmpeg/video.c
+++ b/modules/codec/ffmpeg/video.c
@@ -963,8 +963,7 @@ static int ffmpeg_GetFrameBuf( struct AVCodecContext *p_context,
     p_ff_pic->linesize[2] = p_pic->p[2].i_pitch;
     p_ff_pic->linesize[3] = 0;
 
-    if( p_ff_pic->reference != 0 ||
-        p_sys->i_codec_id == CODEC_ID_H264 /* Bug in libavcodec */ )
+    if( p_ff_pic->reference != 0 )
     {
         p_dec->pf_picture_link( p_dec, p_pic );
     }
@@ -994,8 +993,7 @@ static void ffmpeg_ReleaseFrameBuf( struct AVCodecContext *p_context,
     p_ff_pic->data[2] = NULL;
     p_ff_pic->data[3] = NULL;
 
-    if( p_ff_pic->reference != 0 ||
-        p_dec->p_sys->i_codec_id == CODEC_ID_H264 /* Bug in libavcodec */ )
+    if( p_ff_pic->reference != 0 )
     {
         p_dec->pf_picture_unlink( p_dec, p_pic );
     }




More information about the vlc-devel mailing list