[vlc-devel] [Videolan-devel] [PATCH] Add Dynamic CSA update functionality

Kaloyan Kovachev kkovachev at varna.net
Thu Jun 12 09:28:27 CEST 2008


On Wed, 11 Jun 2008 19:27:01 +0300, [UTF-8?]RГ©mi Denis-Courmont wrote
> Le mercredi 11 juin 2008 19:06:17 Kaloyan Kovachev, vous avez [UTF-8?]Г©critВ :
> > > I am attaching the 'Dynamic CSA' patch too as there were no changes
> > > required and this should be the final version.
> >
> > Ooops, forgot the attachments
> 
> You need to acquire the lock when doing CSA (de)scrambling, not only when 
> changing the keys... Also please call the locks csa_lock, not (de)mux_lock.
> 

Changed the lock names and added the locks around (de)scrambling (attached as
separate patch and as updated full one), but one of the prevoiusly sent
patches (0006a) does only this and I have skipped it, because corruption may
happen only when the active (in use) key is changed and in such case there
will be corupted frames in either case, as it can never happen at the same
frame on the server and the client, so this should save some CPU. If the key
in use is changed it won't cause corruption (on scrambling).

> -- 
> [UTF-8?]RГ©mi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-the-CSA-locks.patch
Type: text/x-patch
Size: 6469 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080612/81eaeef8/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Dynamic-two-keys-CSA.patch
Type: text/x-patch
Size: 19669 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080612/81eaeef8/attachment-0001.bin>


More information about the vlc-devel mailing list