[vlc-devel] [PATCH] Patch to fix bug #1532, and improve http seek times.

Ilkka Ollakka ilkka.ollakka+vlc at oamk.fi
Fri Jun 13 17:58:47 CEST 2008

On to 12. kesäkuuta 2008 13:19:18, Bill C. Riemers wrote:
> This is a patch to improve http seek performance and fix bug 1532.

> offset.   If there is too much data left from the previous request, then
> it resorts to the old behaviour of closing the connection and open a new
> one.
> Bill

Hi Bill,

Seems to work ok for me (tested with mp4 files). Thou little detail: 

>          case ACCESS_CAN_FASTSEEK:
>              pb_bool = (bool*)va_arg( args, bool* );
> -            *pb_bool = false;
> +            // http 1.1 should be just as fast as nfs...
> +            *pb_bool = p_sys->b_seekable;
>              break;

shoudln't this check p_sys->i_version? as it's 0 for http/1.0 and 1 for

> -    if( p_sys->b_continuous )
> -    {
> -        net_Printf( VLC_OBJECT( p_access ), p_sys->fd, pvs,
> +    net_Printf( VLC_OBJECT( p_access ), p_sys->fd, pvs,
>                      "Connection: Keep-Alive\r\n" );
And shouldn't there be code in disconnect/close to send 
"Connection: close" to other end too?

Otherwise I didn't spot any issue with this. Any other care to review?

Ilkka Ollakka
An age is called Dark not because the light fails to shine, but because
people refuse to see it.
		-- James Michener, "Space"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20080613/b536aa61/attachment.sig>

More information about the vlc-devel mailing list