[vlc-devel] [PATCH] Correctly respond to a Connection Close message.

Rémi Denis-Courmont rdenis at simphalempin.com
Sat Jun 14 12:55:06 CEST 2008


Le vendredi 13 juin 2008 21:49:18 Bill C. Riemers, vous avez écrit :
> OK.  This is patch three in the sequence.

> I've restored http CAN_FASTSEEK to false because often http is used over
> high latency networks.

> I've changed avi demux not to require CAN_FASTSEEK, because even over high
> latency networks, the http code has no problem avi's.

If AVI cannot be read at all without seeking, that is the proper solution. 
However, we have had this CAN_FASTSEEK check for almost five years, and many 
many releases. The AVI demux is supposed to work on non-seekable streams! I 
am not very comfortable downgrading from CAN_FASTSEEK to CAN_SEEK until we 
know why it broke (assuming it did break). Besides, it will only fix the 
problem for slow-seekable streams, and not for non-seekable ones.

Please don't patch the AVI stuff, at least not in the same patchset...

-- 
Rémi Denis-Courmont
http://www.remlab.net/



More information about the vlc-devel mailing list